> On Sept. 23, 2015, 7:45 a.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/provisioner/docker/metadata_manager.hpp, line 57
> > <https://reviews.apache.org/r/38137/diff/12/?file=1080146#file1080146line57>
> >
> >     With the pullers refactored out of the store I don't see the need for a 
> > separate metadata manager. The metadata is literally "the metadata of the 
> > store" and it mirrors the set of operations of the store. e.g. 
> > Store::recover() just calls MetadataManager::recover().
> >     
> >     I am not adamant about making it happen in this review though.

Ok, we'll change this next iteration.


> On Sept. 23, 2015, 7:45 a.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/provisioner/docker/paths.hpp, line 36
> > <https://reviews.apache.org/r/38137/diff/12/?file=1080148#file1080148line36>
> >
> >     This diagram doesn't explain some of the methods in this file involving 
> > stuff under the "staging" dir below.
> >     
> >     I imagine with a registry puller the temp_dir looks a bit different.
> >     
> >     ```
> >     staging
> >     |-- <temp_dir_archive>
> >         |-- <layer_id>
> >             |-- VERSION
> >             |-- json
> >             |-- layer.tar
> >     ```

Ya the registry looks different, so I'll just extend it to the point where it 
has the rootfs


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38137/#review99919
-----------------------------------------------------------


On Sept. 22, 2015, 10:15 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38137/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 10:15 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, Till Toenshoff, and Jiang 
> Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Joining all the commits around provisioner and local store into one review so 
> it's easier to review, as patches
> are changing code on top of each other.
> 
> All the commits are going to committed together.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e224060 
>   src/slave/containerizer/provisioner/docker/local_puller.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/message.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/message.proto PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/metadata_manager.hpp 
> PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
> PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/paths.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/paths.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/puller.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/puller.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/store.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/store.cpp 35d1199 
>   src/slave/flags.hpp e31a418 
>   src/slave/flags.cpp add4196 
>   src/tests/containerizer/provisioner_docker_tests.cpp 1b0c304 
> 
> Diff: https://reviews.apache.org/r/38137/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Reply via email to