----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37967/#review100070 -----------------------------------------------------------
High level comment: why not just use pid namespace to kill processes since we already have it? src/linux/cgroups.hpp (line 758) <https://reviews.apache.org/r/37967/#comment157180> Over documented, this is private, so you can just document it in its definition and remove this one. src/linux/cgroups.cpp (line 981) <https://reviews.apache.org/r/37967/#comment157179> s/verified/error/, otherwise reads odd. src/linux/cgroups.cpp (line 1631) <https://reviews.apache.org/r/37967/#comment157164> s/chain/statuses/ - Cong Wang On Sept. 22, 2015, 7:43 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37967/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 7:43 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Added Non-Freezeer Task Killer. 36620 > > > Diffs > ----- > > src/linux/cgroups.hpp 204c53038a1ccfa693f4f2293488cff8cdd60835 > src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f > > Diff: https://reviews.apache.org/r/37967/diff/ > > > Testing > ------- > > > Thanks, > > Joerg Schad > >
