-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37967/#review100082
-----------------------------------------------------------


Tests? Also, link the JIRA ticket in the review board.


src/linux/cgroups.hpp (line 666)
<https://reviews.apache.org/r/37967/#comment157186>

    Any reason you want to expose these two classes in the header? If no one is 
using them right now, please move them to the cpp file (close to their impl.)



src/linux/cgroups.cpp (line 1681)
<https://reviews.apache.org/r/37967/#comment157189>

    Indent should be 2 spaces here.



src/linux/cgroups.cpp (line 1689)
<https://reviews.apache.org/r/37967/#comment157190>

    No period in the end. Also, can you include the error message here:
    ```
    promise.fail(
        "Failed to reap processes of the cgroup: " +
        (future.isError() ? future.failure() : "discarded"));
    ```


- Jie Yu


On Sept. 22, 2015, 7:43 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37967/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 7:43 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Non-Freezeer Task Killer. 36620
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp 204c53038a1ccfa693f4f2293488cff8cdd60835 
>   src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f 
> 
> Diff: https://reviews.apache.org/r/37967/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to