> On Sept. 22, 2015, 10:37 p.m., Jie Yu wrote:
> > src/linux/cgroups.hpp, line 666
> > <https://reviews.apache.org/r/37967/diff/2/?file=1081507#file1081507line666>
> >
> >     Any reason you want to expose these two classes in the header? If no 
> > one is using them right now, please move them to the cpp file (close to 
> > their impl.)

I would like to leave them here as my second patch with tests can access the 
classes in this way.


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37967/#review100082
-----------------------------------------------------------


On Sept. 22, 2015, 7:43 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37967/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 7:43 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Non-Freezeer Task Killer. 36620
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp 204c53038a1ccfa693f4f2293488cff8cdd60835 
>   src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f 
> 
> Diff: https://reviews.apache.org/r/37967/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to