-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38137/#review100226
-----------------------------------------------------------



src/slave/containerizer/provisioner/docker/puller.hpp (line 40)
<https://reviews.apache.org/r/38137/#comment157391>

    Shouldnt this be LayerInfo?



src/slave/containerizer/provisioner/docker/puller.hpp (line 55)
<https://reviews.apache.org/r/38137/#comment157392>

    according to doxygen style guide, the param name and its description should 
be separated by 1 space (uniform separation between all sections).



src/slave/containerizer/provisioner/docker/puller.hpp (line 60)
<https://reviews.apache.org/r/38137/#comment157386>

    I think timeout should be part of the interface. remote puller especially 
should be constrained by time.



src/slave/containerizer/provisioner/docker/puller.cpp (line 39)
<https://reviews.apache.org/r/38137/#comment157393>

    "Failed to get puller for " ?



src/slave/containerizer/provisioner/docker/store.cpp (line 37)
<https://reviews.apache.org/r/38137/#comment157390>

    this should be at the top of includes?



src/slave/containerizer/provisioner/docker/store.cpp (line 257)
<https://reviews.apache.org/r/38137/#comment157396>

    Dont we have to cleanup the created directory?


- Jojy Varghese


On Sept. 22, 2015, 10:15 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38137/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 10:15 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, Till Toenshoff, and Jiang 
> Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Joining all the commits around provisioner and local store into one review so 
> it's easier to review, as patches
> are changing code on top of each other.
> 
> All the commits are going to committed together.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e224060 
>   src/slave/containerizer/provisioner/docker/local_puller.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/message.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/message.proto PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/metadata_manager.hpp 
> PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/metadata_manager.cpp 
> PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/paths.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/paths.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/puller.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/puller.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/store.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/store.cpp 35d1199 
>   src/slave/flags.hpp e31a418 
>   src/slave/flags.cpp add4196 
>   src/tests/containerizer/provisioner_docker_tests.cpp 1b0c304 
> 
> Diff: https://reviews.apache.org/r/38137/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Reply via email to