----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38416/#review100260 -----------------------------------------------------------
3rdparty/libprocess/include/process/http.hpp (lines 657 - 658) <https://reviews.apache.org/r/38416/#comment157419> It seems odd to have the code duplicated above, can you set the status using the code? E.g. ``` code = Status::SERVICE_UNAVAILABLE; status = stringify(code)+ " Service Unavailable"; ``` Or why don't we leverage the statuses map here? We have redundant information =/ - Ben Mahler On Sept. 23, 2015, 7:59 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38416/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2015, 7:59 a.m.) > > > Review request for mesos, Anand Mazumdar, Jie Yu, Jojy Varghese, and Jiang > Yan Xu. > > > Bugs: MESOS-3429 > https://issues.apache.org/jira/browse/MESOS-3429 > > > Repository: mesos > > > Description > ------- > > Allow HTTP response codes to be checked with code. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > fbd6cf7967173495875a8ea90ed28ade88b982a2 > 3rdparty/libprocess/src/decoder.hpp > 67a5135f302153e376e8dfe8db82aa0b15449389 > 3rdparty/libprocess/src/http.cpp 9ad613a16c379b6d76a9a0f8d6160fe23a182fd4 > > Diff: https://reviews.apache.org/r/38416/diff/ > > > Testing > ------- > > make > > > Thanks, > > Timothy Chen > >
