> On Sept. 25, 2015, 5:48 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [38416] > > > > Failed command: ./support/apply-review.sh -n -r 38416 > > > > Error: > > 2015-09-25 17:48:15 URL:https://reviews.apache.org/r/38416/diff/raw/ > > [27994/27994] -> "38416.patch" [1] > > Successfully applied: Allow HTTP response codes to be checked with code. > > > > Allow HTTP response codes to be checked with code. > > > > > > Review: https://reviews.apache.org/r/38416 > > Checking 8 files using filter > > --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo > > Total errors found: 0 > > ERROR: Commit spanning multiple projects. > > > > Please use separate commits for mesos, libprocess and stout. > > > > Paths grouped by project: > > mesos: > > src/scheduler/scheduler.cpp > > libprocess: > > 3rdparty/libprocess/include/process/http.hpp > > 3rdparty/libprocess/src/decoder.hpp > > 3rdparty/libprocess/src/http.cpp > > 3rdparty/libprocess/src/process.cpp > > 3rdparty/libprocess/src/tests/benchmarks.cpp > > 3rdparty/libprocess/src/tests/http_tests.cpp > > 3rdparty/libprocess/src/tests/process_tests.cpp > > Failed to commit patch
I'll split the patch when I commit, please review the current code. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38416/#review100633 ----------------------------------------------------------- On Sept. 25, 2015, 4:50 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38416/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2015, 4:50 p.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, Jie Yu, Jojy Varghese, > and Jiang Yan Xu. > > > Bugs: MESOS-3429 > https://issues.apache.org/jira/browse/MESOS-3429 > > > Repository: mesos > > > Description > ------- > > Allow HTTP response codes to be checked with code. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > fbd6cf7967173495875a8ea90ed28ade88b982a2 > 3rdparty/libprocess/src/decoder.hpp > 67a5135f302153e376e8dfe8db82aa0b15449389 > 3rdparty/libprocess/src/http.cpp 9ad613a16c379b6d76a9a0f8d6160fe23a182fd4 > 3rdparty/libprocess/src/process.cpp > 4afa30569b4d235637b49a624602e6b199c32e0e > 3rdparty/libprocess/src/tests/benchmarks.cpp > 97c81b8e61a75771e5bf7d46505cec4e0c0f404a > 3rdparty/libprocess/src/tests/http_tests.cpp > d0b9399d38fa284466a012a21080b1d9007af98b > 3rdparty/libprocess/src/tests/process_tests.cpp > 1023500ac2e3c55be955c4686e7f720eba6b4cc9 > src/scheduler/scheduler.cpp ee146eb81a8ad72bc04c62d1e223de6aa27b351d > > Diff: https://reviews.apache.org/r/38416/diff/ > > > Testing > ------- > > make > > > Thanks, > > Timothy Chen > >
