> On Sept. 29, 2015, 9:42 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/socket.cpp, lines 79-81 > > <https://reviews.apache.org/r/38809/diff/4/?file=1087354#file1087354line79> > > > > We're using `s.get()` above here, so `owned` should never be `true`? > > Chi Zhang wrote: > owned is determined upon entering the function? (we just reuse the > variable name if s is none)
I see, it gets re-assigned. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38809/#review101028 ----------------------------------------------------------- On Sept. 29, 2015, 8:30 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38809/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2015, 8:30 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-3519 > https://issues.apache.org/jira/browse/MESOS-3519 > > > Repository: mesos > > > Description > ------- > > socket: refactor to use Option and fix file descriptor leaks. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp 817cb37 > 3rdparty/libprocess/src/socket.cpp 5879423 > > Diff: https://reviews.apache.org/r/38809/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Chi Zhang > >
