----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38809/#review101028 -----------------------------------------------------------
3rdparty/libprocess/src/socket.cpp (lines 79 - 81) <https://reviews.apache.org/r/38809/#comment158331> We're using `s.get()` above here, so `owned` should never be `true`? 3rdparty/libprocess/src/socket.cpp (lines 91 - 93) <https://reviews.apache.org/r/38809/#comment158332> We're using `s.get()` above here, so `owned` should never be `true`? - Joris Van Remoortere On Sept. 29, 2015, 8:30 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38809/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2015, 8:30 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-3519 > https://issues.apache.org/jira/browse/MESOS-3519 > > > Repository: mesos > > > Description > ------- > > socket: refactor to use Option and fix file descriptor leaks. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp 817cb37 > 3rdparty/libprocess/src/socket.cpp 5879423 > > Diff: https://reviews.apache.org/r/38809/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Chi Zhang > >
