> On Sept. 30, 2015, 5:10 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 19 > > <https://reviews.apache.org/r/38869/diff/2/?file=1087494#file1087494line19> > > > > Shouldn't this go at the bottom of the includes?
I believe we are still trying to follow the guideline of including the header that we're implementing as the first file in the include list. I recognize this is not consistent in the code-base. Joerg is trying to fix that. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38869/#review101127 ----------------------------------------------------------- On Sept. 30, 2015, 1:08 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38869/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2015, 1:08 a.m.) > > > Review request for mesos, Ben Mahler, Cody Maloney, Artem Harutyunyan, and > Joseph Wu. > > > Bugs: MESOS-3554 > https://issues.apache.org/jira/browse/MESOS-3554 > > > Repository: mesos > > > Description > ------- > > This improves the compilation time of Mesos significantly, allowing > developers to iterate more quickly on allocator changes. > > > Diffs > ----- > > src/Makefile.am 8aa456611dd5405336dd7b0c19ba4a942ea1c805 > src/master/allocator/mesos/hierarchical.hpp > f3a9b9d799695c11caad8ae64e1a53e08bb6e63d > src/master/allocator/mesos/hierarchical.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38869/diff/ > > > Testing > ------- > > make check > touched hierarchical.cpp and recompiled. Verified we only rebuild the module > and relink. > > > Thanks, > > Joris Van Remoortere > >
