-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38869/#review101160
-----------------------------------------------------------


Hm.. it is suprising that touching this header requires wide re-compilation. 
Could we audit why that is?

Looking through the includes, I can see tests/cluster.hpp pulls this in, but we 
should have a .cpp to avoid the dependency in the header. This should yield 
more dependency removals since we can cut other includes. The other culprit 
looks to be tests/mesos.hpp which exposes an allocator wrapper for mocking. 
We've been planning to split out the mocks into relevant mocks/*.hpp files, so 
this could be migrated to a mocks/allocator.hpp file that is only included when 
needed in a test. FWICT only 5 test files need this.

Doing the dependency cleanup should reduce the need for this refactor, and help 
speed up compilation more generally. I'm curious about the implications of this 
pattern for our other templated headers, so hoping to be able to avoid if 
possible :)

- Ben Mahler


On Sept. 30, 2015, 1:08 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38869/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 1:08 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Cody Maloney, Artem Harutyunyan, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-3554
>     https://issues.apache.org/jira/browse/MESOS-3554
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This improves the compilation time of Mesos significantly, allowing
> developers to iterate more quickly on allocator changes.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 8aa456611dd5405336dd7b0c19ba4a942ea1c805 
>   src/master/allocator/mesos/hierarchical.hpp 
> f3a9b9d799695c11caad8ae64e1a53e08bb6e63d 
>   src/master/allocator/mesos/hierarchical.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38869/diff/
> 
> 
> Testing
> -------
> 
> make check
> touched hierarchical.cpp and recompiled. Verified we only rebuild the module 
> and relink.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to