> On Oct. 13, 2015, 5:20 p.m., Michael Park wrote: > > All nits. > > > > ``` > > make check -j 4 GTEST_FILTER="" 1984.45s user 77.00s system 367% cpu > > 9:20.95 total > > make check -j 4 GTEST_FILTER="" 30.08s user 8.57s system 90% cpu 42.577 > > total > > ```
Oops. The `make check` numbers represent the compilation times for when a change is made in the implementation. (1) Before: Added a comment in the function body in `hierarchical.hpp`. (2) After: Added a comment in the function body in `hierarchical.cpp`. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38869/#review102475 ----------------------------------------------------------- On Oct. 13, 2015, 8:51 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38869/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 8:51 a.m.) > > > Review request for mesos, Ben Mahler, Cody Maloney, Artem Harutyunyan, Joseph > Wu, and Michael Park. > > > Bugs: MESOS-3554 > https://issues.apache.org/jira/browse/MESOS-3554 > > > Repository: mesos > > > Description > ------- > > This improves the compilation time of Mesos significantly, allowing > developers to iterate more quickly on allocator changes. > > > Diffs > ----- > > src/CMakeLists.txt 536a99f3dc2f48e6002e70b605598f4d218a4324 > src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e > src/master/allocator/mesos/hierarchical.hpp > d57c55e2f173c3054a04322a33ba590c67b82e4e > src/master/allocator/mesos/hierarchical.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38869/diff/ > > > Testing > ------- > > make check > touched hierarchical.cpp and recompiled. Verified we only rebuild the module > and relink. > > > Thanks, > > Joris Van Remoortere > >
