----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review101387 -----------------------------------------------------------
src/slave/containerizer/provisioner/docker/spec.hpp (line 37) <https://reviews.apache.org/r/38901/#comment158763> End all comments with a period. src/tests/containerizer/provisioner_docker_tests.cpp (line 321) <https://reviews.apache.org/r/38901/#comment158765> No need to abort, just use ASSERT_SOME src/tests/containerizer/provisioner_docker_tests.cpp (line 357) <https://reviews.apache.org/r/38901/#comment158767> How about call it invalid instead of insufficient src/tests/containerizer/provisioner_docker_tests.cpp (line 361) <https://reviews.apache.org/r/38901/#comment158768> What's invalid about this JSON? src/tests/containerizer/provisioner_docker_tests.cpp (line 368) <https://reviews.apache.org/r/38901/#comment158766> ditto - Timothy Chen On Oct. 2, 2015, 8:10 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38901/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2015, 8:10 p.m.) > > > Review request for mesos, Jojy Varghese and Timothy Chen. > > > Bugs: MESOS-2972 > https://issues.apache.org/jira/browse/MESOS-2972 > > > Repository: mesos > > > Description > ------- > > Serialize Docker Image Spec as Protobuf > > > Diffs > ----- > > src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 > src/Makefile.am f060998bb08cdb071db5a2e85dfbad805dab45e9 > src/slave/containerizer/provisioner/docker/message.proto > bbac2e6c1f40a7ca3f9227baca56a44cd43f58c6 > src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION > src/tests/containerizer/provisioner_docker_tests.cpp > d895eb9d0723e52cff8b21ef2deeaef1911d019c > > Diff: https://reviews.apache.org/r/38901/diff/ > > > Testing > ------- > > make check (ubuntu 14.04 + clang++-3.6) > > > Thanks, > > Gilbert Song > >
