----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review102103 -----------------------------------------------------------
Ship it! Ship It! src/tests/containerizer/provisioner_docker_tests.cpp (line 241) <https://reviews.apache.org/r/38901/#comment159610> You don't need to use TemporaryDirectoryTest since you're not writing any files. You probably can just use ::testing::Test as base - Timothy Chen On Oct. 7, 2015, 6:57 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38901/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 6:57 p.m.) > > > Review request for mesos, Jojy Varghese and Timothy Chen. > > > Bugs: MESOS-2972 > https://issues.apache.org/jira/browse/MESOS-2972 > > > Repository: mesos > > > Description > ------- > > Serialize Docker Image Spec as Protobuf > > > Diffs > ----- > > src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d > src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba > src/slave/containerizer/provisioner/docker/message.proto > bbac2e6c1f40a7ca3f9227baca56a44cd43f58c6 > src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION > src/tests/containerizer/provisioner_docker_tests.cpp > d895eb9d0723e52cff8b21ef2deeaef1911d019c > > Diff: https://reviews.apache.org/r/38901/diff/ > > > Testing > ------- > > make check (ubuntu 14.04 + clang++-3.6) > > > Thanks, > > Gilbert Song > >
