-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38901/#review102105
-----------------------------------------------------------


LGTM, Just some minor comments/concerns about including `headers` that we 
need/style issues. Can you do a sweep of the `includes` in case I missed 
pointing some of them here.


src/Makefile.am (line 852)
<https://reviews.apache.org/r/38901/#comment159611>

    Nit: Can we align the trailing `` ?



src/slave/containerizer/provisioner/docker/spec.hpp (line 18)
<https://reviews.apache.org/r/38901/#comment159619>

    We generally prefer header files that are `complete` i.e. they compile on 
their own. Can you ensure that we include `stout/json.hpp` here since it has 
`JSON::Object`. Also , do a sweep of the other includes.



src/slave/containerizer/provisioner/docker/spec.hpp (line 22)
<https://reviews.apache.org/r/38901/#comment159618>

    Do we need this ? If not, remove this include.



src/slave/containerizer/provisioner/docker/spec.cpp (line 20)
<https://reviews.apache.org/r/38901/#comment159616>

    Do you need this ? If not remove it



src/slave/containerizer/provisioner/docker/spec.cpp (line 24)
<https://reviews.apache.org/r/38901/#comment159615>

    Do you need this ? If not remove it



src/tests/containerizer/provisioner_docker_tests.cpp (line 240)
<https://reviews.apache.org/r/38901/#comment159614>

    Remove this comment. It's Redundant/self-explanatory here.



src/tests/containerizer/provisioner_docker_tests.cpp (line 325)
<https://reviews.apache.org/r/38901/#comment159612>

    s/EXPECT_SOME/ASSERT_SOME , since it makes no sense to continue this test 
if this fails.



src/tests/containerizer/provisioner_docker_tests.cpp (line 331)
<https://reviews.apache.org/r/38901/#comment159613>

    Nit: Does it make sense to change the ASSERT_EQ to EXPECT_EQ ? 
    
    Might help the user to see a list of all the things that failed instead of 
just aborting at the first failure.



src/tests/containerizer/provisioner_docker_tests.cpp (line 357)
<https://reviews.apache.org/r/38901/#comment159617>

    How about :
    
    `// This is an invalid manifest. The required fields 'signatures' and 
'schemaVersion' are not set.`
    
    While testing, we only make assumptions about the things we are testing as 
part of our test. The `validateManifest` call is not part of this test, so its 
better to just ignore/not mention it.


- Anand Mazumdar


On Oct. 7, 2015, 6:57 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38901/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2015, 6:57 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese and Timothy Chen.
> 
> 
> Bugs: MESOS-2972
>     https://issues.apache.org/jira/browse/MESOS-2972
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Serialize Docker Image Spec as Protobuf
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d 
>   src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 
>   src/slave/containerizer/provisioner/docker/message.proto 
> bbac2e6c1f40a7ca3f9227baca56a44cd43f58c6 
>   src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d895eb9d0723e52cff8b21ef2deeaef1911d019c 
> 
> Diff: https://reviews.apache.org/r/38901/diff/
> 
> 
> Testing
> -------
> 
> make check (ubuntu 14.04 + clang++-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to