----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/#review101816 -----------------------------------------------------------
Partial, entirely incomplete but maybe helpful review :) 3rdparty/libprocess/include/process/http.hpp (line 493) <https://reviews.apache.org/r/37999/#comment159318> THe RFCs always use `WWW-Authenticate`, shouldn't we as well here and everywhere else? 3rdparty/libprocess/src/process.cpp (line 2611) <https://reviews.apache.org/r/37999/#comment159314> s/Tecnically/technically/ s/principa/principal/ 3rdparty/libprocess/src/process.cpp (lines 2643 - 2647) <https://reviews.apache.org/r/37999/#comment159315> This still makes me think we should fix the flaky fetcher tests before anything else. Lets put some combined efforts into that please. - Till Toenshoff On Sept. 30, 2015, 8:20 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37999/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2015, 8:20 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-3231 > https://issues.apache.org/jira/browse/MESOS-3231 > > > Repository: mesos > > > Description > ------- > > Introduces the authenticator manager, which is a class which handles the > actual authentication procedure during the execution of > `ProcessManager::handle()` and it also takes care of the life cycle of > instances of http::Authenticator. > > No tests are added at this point since no public API is generated, the goal > of this patch is to implement the manager and verify nothing breaks > afterwards. Authenticator manager tests proper come in a latter patch. > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am > fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e > 3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION > 3rdparty/libprocess/include/process/event.hpp > 16ddbd77afa6efdf6bad201aa497ee102aa863ae > 3rdparty/libprocess/include/process/http.hpp > ba3f0bc7df33795e332c374fbad04106b9d56416 > 3rdparty/libprocess/src/process.cpp > d1c81f1d244f02bf42cab97198587ce1b8c7c407 > > Diff: https://reviews.apache.org/r/37999/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
