----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39230/#review102306 -----------------------------------------------------------
Ship it! It's marginal, but I think ```AC_LANG_PROGRAM``` is a little clearer that ```AC_LANG_SOURCE```. If you are going to rely on the diagnostic pragmas, an alternative is to simply use those to disable the warning in the SASL wrappers which is a little more tightly scoped. - James Peach On Oct. 12, 2015, 1:25 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39230/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2015, 1:25 p.m.) > > > Review request for mesos and switched to 'mcypark'. > > > Bugs: MESOS-3030 > https://issues.apache.org/jira/browse/MESOS-3030 > > > Repository: mesos > > > Description > ------- > > This patch also removes some useless CFLAGS handling on the SASL CRAM-MD5 > checks of the configuration. > > > Diffs > ----- > > configure.ac 66f9b32773861d2921d99189e0fbcaea48c456a9 > > Diff: https://reviews.apache.org/r/39230/diff/ > > > Testing > ------- > > ./configure && make check > OSX, clang3.7 + gcc4.9 > > > Thanks, > > Till Toenshoff > >
