> On Sept. 11, 2015, 6:57 p.m., Joseph Wu wrote:
> > Ship it!
> > 
> > I pointed out a bunch of would-be-nice-to-refactor lines.  But I don't 
> > think it's critical to change them to ship this.

Let's make these changes in a separate patch.


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38307/#review98656
-----------------------------------------------------------


On Oct. 14, 2015, 8:39 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38307/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2015, 8:39 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joseph Wu, Michael Park, and 
> Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 
> d1c81f1d244f02bf42cab97198587ce1b8c7c407 
>   3rdparty/libprocess/src/test-master.cpp 
> 5ce91710031e6fce3e1b5791eb782941aef9f10a 
>   3rdparty/libprocess/src/test-slave.cpp 
> 03fa8e61f46dc70647f478c5adef67d8de6cf5c2 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 
> bb9ced8933bf2bb97ae6b3cffdb5528676e53c11 
>   3rdparty/libprocess/src/tests/decoder_tests.cpp 
> f1963fdb4c27faa9055e9f9f6edd850cebd15948 
>   3rdparty/libprocess/src/tests/encoder_tests.cpp 
> 5ad5fd415baca4423c3054a42bd9e175b72153b8 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 38f3ad7e46f5b6ef4850cdf7fdcc115715e98472 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> a7135ee0cfeef7c07ebe41815f47df24dd2b713c 
>   3rdparty/libprocess/src/tests/limiter_tests.cpp 
> ba722509fefc3cd592b6f41d02a0b12d5adf7e00 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp 
> 8f15ee7e89e5346d306df71eb06a7161da13af48 
>   3rdparty/libprocess/src/tests/mutex_tests.cpp 
> 484727fd36c04f8a3380808d0f75eaad11338331 
>   3rdparty/libprocess/src/tests/owned_tests.cpp 
> 3ef76b8d5426ea10f63bf78b96f45046dd8a955a 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> ffd260a3fa2e49b3de183ba7b392b71afaaba2e5 
>   3rdparty/libprocess/src/tests/queue_tests.cpp 
> a6a0dab42ea1674256e8990255bf507aa24f24b8 
>   3rdparty/libprocess/src/tests/reap_tests.cpp 
> a844ae2b863b98c49ec8fac79e905b3c04a142fc 
>   3rdparty/libprocess/src/tests/sequence_tests.cpp 
> 88de001aad259c3035f2ff20ed61e7e119a73f54 
>   3rdparty/libprocess/src/tests/shared_tests.cpp 
> 74ea26060ac2800cb98dffbfc90494871d0a9e21 
>   3rdparty/libprocess/src/tests/ssl_client.cpp 
> 9ae59e54bab954b1a931dbc3bd2f1540deb9f5aa 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> ee30a02b112d20bced49ead15447d412f4005a8f 
>   3rdparty/libprocess/src/tests/statistics_tests.cpp 
> 657d27aed18949fa8200236662f2897bdddd2ef4 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 25d4a7b2fe35fb95f3f19f39bc81d6e50f5c25a3 
>   3rdparty/libprocess/src/tests/system_tests.cpp 
> 25436ea2e977d667037e2d7344a8804ec35b27b9 
>   3rdparty/libprocess/src/tests/time_tests.cpp 
> 60791ff20671859a0da91524ae8e40ff52c907d0 
>   3rdparty/libprocess/src/tests/timeseries_tests.cpp 
> ec6f4868a65b89244fb4bb8234a77c87831863c3 
> 
> Diff: https://reviews.apache.org/r/38307/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to