----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39449/#review103145 -----------------------------------------------------------
docs/c++-style-guide.md (line 241) <https://reviews.apache.org/r/39449/#comment161088> s/seperate/separate docs/c++-style-guide.md (line 243) <https://reviews.apache.org/r/39449/#comment161090> I would specify what .ccp file is this example related to. I think we have the 'related header' rule, where, if this where `master/flags.cpp` then `master/flags.hpp` should be included first. - Marco Massenzio On Oct. 19, 2015, 6:58 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39449/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 6:58 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-2275 > https://issues.apache.org/jira/browse/MESOS-2275 > > > Repository: mesos > > > Description > ------- > > Documented order of includes. > > > Diffs > ----- > > docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad > > Diff: https://reviews.apache.org/r/39449/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
