-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39457/#review103218
-----------------------------------------------------------



src/messages/messages.proto (line 77)
<https://reviews.apache.org/r/39457/#comment161201>

    s/from the agent up to the framework/from the agent to the framework ?



src/messages/messages.proto (lines 123 - 128)
<https://reviews.apache.org/r/39457/#comment161200>

    Seems it is OK to remove this as I did not see anyone who is using it.
    
    If this removed, then the master also needs to be updated by removing such 
message.



src/messages/messages.proto (line 139)
<https://reviews.apache.org/r/39457/#comment161219>

    s/sent/sends?



src/messages/messages.proto (line 153)
<https://reviews.apache.org/r/39457/#comment161218>

    s/sent/sends?



src/messages/messages.proto (line 413)
<https://reviews.apache.org/r/39457/#comment161203>

    s/slave/agent and other places?



src/messages/messages.proto (lines 499 - 500)
<https://reviews.apache.org/r/39457/#comment161211>

    s/slave/agent



src/messages/messages.proto (line 508)
<https://reviews.apache.org/r/39457/#comment161210>

    s/slave/agent



src/messages/messages.proto (line 527)
<https://reviews.apache.org/r/39457/#comment161209>

    s/slave/agent



src/messages/messages.proto (line 546)
<https://reviews.apache.org/r/39457/#comment161208>

    s/slave/agent



src/messages/messages.proto (line 603)
<https://reviews.apache.org/r/39457/#comment161206>

    What about make all of the comments using same tone?
    
    For example:
    Notifies the scheduler about terminated executors.
    
    Ditto as following



src/messages/messages.proto (line 640)
<https://reviews.apache.org/r/39457/#comment161205>

    Not only the agent but also all of the frameworks on the agent will be 
shutdown, can we put this in the document?



src/messages/messages.proto (line 665)
<https://reviews.apache.org/r/39457/#comment161202>

    s/faiure/failure


- Guangya Liu


On 十月 20, 2015, 12:42 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39457/
> -----------------------------------------------------------
> 
> (Updated 十月 20, 2015, 12:42 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3759
>     https://issues.apache.org/jira/browse/MESOS-3759
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A brief summary of each message was added.  
> 
> For messages with an associated Event/Call API object, a reference to the 
> object was added.
> Additionally, there is a great deal of documentation overlap between these 
> messages and the comments in mesos/scheduler.hpp and 
> v1/scheduler/scheduler.proto.  Where necessary, some notes were added about 
> the backwards compatibility of messages which are not instantiated in the 
> code base.
> 
> 
> Diffs
> -----
> 
>   src/messages/messages.proto ea9a67e169a8a359a12be93b804783c7dcced0b7 
> 
> Diff: https://reviews.apache.org/r/39457/diff/
> 
> 
> Testing
> -------
> 
> None.  (Comment change only)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to