> On Oct. 20, 2015, 1:23 a.m., Guangya Liu wrote: > > > > Joseph Wu wrote: > For now, I'll keep "agent". I'm fairly certain we refer to agents as > agents now. > > Guangya Liu wrote: > Joseph, do you have any reasons for why not update "slave" to "agent" in > the comments? When I was fixing https://reviews.apache.org/r/37993/ , I was > asked to change all "slave" to "agent" to keep consistent.
This is mostly due to the audience of the code. People who read this file are going to be Mesos contributors. And interally, we already use "agent". The allocator comments you made are external facing (to module writers). We're still in the process (I think) of converting external docs from "slave" to "agent". For those, it's more important to stay consistent between docs than to be politically correct. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39457/#review103218 ----------------------------------------------------------- On Oct. 20, 2015, 10:26 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39457/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2015, 10:26 a.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Bugs: MESOS-3759 > https://issues.apache.org/jira/browse/MESOS-3759 > > > Repository: mesos > > > Description > ------- > > A brief summary of each message was added. > > For messages with an associated Event/Call API object, a reference to the > object was added. > Additionally, there is a great deal of documentation overlap between these > messages and the comments in mesos/scheduler.hpp and > v1/scheduler/scheduler.proto. Where necessary, some notes were added about > the backwards compatibility of messages which are not instantiated in the > code base. > > > Diffs > ----- > > src/messages/messages.proto ea9a67e169a8a359a12be93b804783c7dcced0b7 > > Diff: https://reviews.apache.org/r/39457/diff/ > > > Testing > ------- > > None. (Comment change only) > > > Thanks, > > Joseph Wu > >
