> On Oct. 20, 2015, 1:23 a.m., Guangya Liu wrote: > >
For now, I'll keep "agent". I'm fairly certain we refer to agents as agents now. > On Oct. 20, 2015, 1:23 a.m., Guangya Liu wrote: > > src/messages/messages.proto, lines 132-137 > > <https://reviews.apache.org/r/39457/diff/3/?file=1101370#file1101370line132> > > > > Seems it is OK to remove this as I did not see anyone who is using it. > > > > If this removed, then the master also needs to be updated by removing > > such message. There are quite a few messages in this file that no longer *appear* to be used (mentioned in the review description). I need to check with someone (i.e. BenH) to know if it is really not being used. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39457/#review103218 ----------------------------------------------------------- On Oct. 19, 2015, 5:42 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39457/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 5:42 p.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Bugs: MESOS-3759 > https://issues.apache.org/jira/browse/MESOS-3759 > > > Repository: mesos > > > Description > ------- > > A brief summary of each message was added. > > For messages with an associated Event/Call API object, a reference to the > object was added. > Additionally, there is a great deal of documentation overlap between these > messages and the comments in mesos/scheduler.hpp and > v1/scheduler/scheduler.proto. Where necessary, some notes were added about > the backwards compatibility of messages which are not instantiated in the > code base. > > > Diffs > ----- > > src/messages/messages.proto ea9a67e169a8a359a12be93b804783c7dcced0b7 > > Diff: https://reviews.apache.org/r/39457/diff/ > > > Testing > ------- > > None. (Comment change only) > > > Thanks, > > Joseph Wu > >
