> On Oct. 20, 2015, 7 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/owned.hpp, lines 202-203 > > <https://reviews.apache.org/r/39429/diff/2/?file=1100746#file1100746line202> > > > > In libprocess we use `snake_case`. > > You can also consider removing the temporary. I'm fine either way as it > > serves as documentation. If you keep the temporary can you make it `const`? > > :-D
Woah, I had no idea we use snake_case in libprocess. I think we should add this to the style guide. Also I notice a few places (mostly test code, plus src/time.cpp) that don't use snake_case. Is it worth fixing these? - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39429/#review103292 ----------------------------------------------------------- On Oct. 20, 2015, 8:18 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39429/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2015, 8:18 p.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Bugs: MESOS-3326 > https://issues.apache.org/jira/browse/MESOS-3326 > > > Repository: mesos > > > Description > ------- > > See MESOS-3326. We adopted std::atomic in most of the code base earlier > (commits > 87de003c6e8a, 4b938052b6af, and 4a01850c5540), but a few places were omitted; > those locations are fixed by this commit. > > There's one last place to fix: we use the GCC intrinsic __sync_synchronize() > in > 3rdparty/libprocess/include/process/logging.h. Because that is used to protect > modifications to the FLAGS_v variable defined by glog, we can't easily adapt > it > to use std::atomic. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/owned.hpp > 17c42614155fed8fec185f29f9a9babb71ff5f85 > 3rdparty/libprocess/include/process/shared.hpp > 021807b961bb55f11c9e04327135bd83f4d86c21 > 3rdparty/libprocess/src/tests/process_tests.cpp > a3c57a261c09f7b76b78225719e64a26f2d66cd3 > > Diff: https://reviews.apache.org/r/39429/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
