----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review103402 -----------------------------------------------------------
src/master/master.cpp (line 510) <https://reviews.apache.org/r/39043/#comment161461> may need a rephrase here - Jian Qiu On Oct. 21, 2015, 1:20 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39043/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2015, 1:20 p.m.) > > > Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till > Toenshoff. > > > Bugs: MESOS-3756 > https://issues.apache.org/jira/browse/MESOS-3756 > > > Repository: mesos > > > Description > ------- > > 1. Adds a flag to load an HTTP Authenticator module from the flags. > 2. If provided, uses the credentials file to initialize the default HTTP > Authenticator. > 3. Updates the existing endpoints which implement their own basic HTTP > authenticator with the libprocess one. > 4. Updates one test which expected the wrong results since now credentials > are checked before the body of the request. > > > Diffs > ----- > > src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 > src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 > src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 > src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 > src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 > src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 > src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa > > Diff: https://reviews.apache.org/r/39043/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >