----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ -----------------------------------------------------------
(Updated Nov. 4, 2015, 12:33 p.m.) Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till Toenshoff. Changes ------- Addresses issues in Jian Qiu's review. Bugs: MESOS-3756 https://issues.apache.org/jira/browse/MESOS-3756 Repository: mesos Description ------- 1. Adds a flag to load an HTTP Authenticator module from the flags. 2. If provided, uses the credentials file to initialize the default HTTP Authenticator. 3. Updates the existing endpoints which implement their own basic HTTP authenticator with the libprocess one. 4. Updates one test which expected the wrong results since now credentials are checked before the body of the request. Diffs (updated) ----- src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 src/master/http.cpp 9d20346460b4f9659aacba3fcb950ab564ba9d0d src/master/master.hpp b19f23be135d191ce119cf87fd25c4d6746faed3 src/master/master.cpp cbae27e7a4059a72bc69e152ec8adaf4ef725965 Diff: https://reviews.apache.org/r/39043/diff/ Testing ------- make check Thanks, Alexander Rojas