----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39006/#review103460 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp (line 247) <https://reviews.apache.org/r/39006/#comment161523> Don't we need `#include <stout/os/strerror.hpp>` here too? 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp (line 264) <https://reviews.apache.org/r/39006/#comment161524> Same as above. 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (line 64) <https://reviews.apache.org/r/39006/#comment161527> ditto. 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp (line 548) <https://reviews.apache.org/r/39006/#comment161525> ditto. - Kapil Arya On Oct. 8, 2015, 10:36 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39006/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2015, 10:36 a.m.) > > > Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff. > > > Bugs: MESOS-3551 > https://issues.apache.org/jira/browse/MESOS-3551 > > > Repository: mesos > > > Description > ------- > > Switch call sites to using safe strerror_r wrapper. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp > 12ba1ca861114e60f8276c0ee91c543abcfc2519 > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp > d1e2df6151149e03ffb4a76e2c24ff78b891e016 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp > 7eb51e8771e95f57548fc35753e75c6d56cd97cd > 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp > e740d5bc0f0cc5cf8e99b2064c1e39c08282da67 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e > > Diff: https://reviews.apache.org/r/39006/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Bannier > >
