> On Oct. 23, 2015, 9:15 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp, line 34 > > <https://reviews.apache.org/r/39583/diff/1/?file=1103900#file1103900line34> > > > > This doesn't use any instance data so could probably be either `const`, > > `static`, or a free function.
Ah, thanks, Benjamin! I'm a complete C++ noob, unforunately. :) - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/#review103746 ----------------------------------------------------------- On Oct. 23, 2015, 8:57 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39583/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 8:57 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Added `WindowsError` to parallel `ErrnoError`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > ba2836a72ceee948cb43364e80ada9f132f33d04 > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp > fdd33512c8d8752093f72f597a7d647eb5e3c285 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/39583/diff/ > > > Testing > ------- > > `make check` from autotools on Ubuntu 15. > `make check` from CMake on OS X 10.10. > Ran `check` project in VS on Windows 10. > > > Thanks, > > Alex Clemmer > >
