-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39559/#review103815
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp (line 
34)
<https://reviews.apache.org/r/39559/#comment161905>

    `strlen()` might be better/more-readable.



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp (lines 
36 - 41)
<https://reviews.apache.org/r/39559/#comment161904>

    The posix spec says that `XXXXXX` suffix is required, so 
`strings::endsWith` would be a better check.



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp (line 
48)
<https://reviews.apache.org/r/39559/#comment161906>

    That `- 1` doesn't match the "size" described by the variable name.  Seems 
like you're describing the `max_alphabet_index`.



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp (lines 
62 - 74)
<https://reviews.apache.org/r/39559/#comment161908>

    If you use `strings::endsWith` above, you won't need this validation.


- Joseph Wu


On Oct. 22, 2015, 11:23 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39559/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 11:23 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Implemented `os::mkdtemp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdtemp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/mkdtemp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> b6afe0e76366d0bc68d37097ced83a1e14828d84 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 3e6f2aafd0f541f512025dfa683ab4178701f7c4 
> 
> Diff: https://reviews.apache.org/r/39559/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to