-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39559/#review104778
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/mkdtemp.hpp (line 16)
<https://reviews.apache.org/r/39559/#comment163018>

    `<stdlib.h>`?



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/mkdtemp.hpp (line 18)
<https://reviews.apache.org/r/39559/#comment163017>

    `<string>`
    `<stout/error.hpp>`



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp (lines 
19 - 21)
<https://reviews.apache.org/r/39559/#comment163027>

    order?



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp (line 
34)
<https://reviews.apache.org/r/39559/#comment163020>

    Let's try to be consistent about capitalizing after `NOTE:`



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp (lines 
34 - 71)
<https://reviews.apache.org/r/39559/#comment163026>

    Can you please explain why we can't just use `mktemp` here?
    I acknowledge that the idea behind `mktemp` is to guarantee that the 
directory name can't collide with an existing one, but the custom 
implementation you provide also doesn't do that while generating the name, 
correct?



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp (line 
52)
<https://reviews.apache.org/r/39559/#comment163021>

    Let's try to be consistent about capitalizing after `NOTE:`


- Joris Van Remoortere


On Oct. 30, 2015, 5:53 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39559/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2015, 5:53 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Implemented `os::mkdtemp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 67b142bbc2d80f40a1e893cc5813d58dd2aa8381 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> fc2df6831ae2cb1a91c7a8cc92965939576e575d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdtemp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/mkdtemp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> e26df59d9b837e1f4a4b92577f0a3de4b9076cb4 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> edf17d5ad8efbc988e909bfb8ffa5a015ecdc89d 
> 
> Diff: https://reviews.apache.org/r/39559/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to