> On Oct. 23, 2015, 11:18 p.m., Till Toenshoff wrote:
> > src/slave/containerizer/linux_launcher.cpp, lines 187-190
> > <https://reviews.apache.org/r/39604/diff/5/?file=1105466#file1105466line187>
> >
> >     It is pretty well readable already, hence this point is VERY minor...
> >     
> >     I believe this should be formatted like any other boolean expression, 
> > not a function definition or invocation.
> >     Please see 
> > http://google.github.io/styleguide/cppguide.html#Boolean_Expressions which 
> > we inherit here.

```
  return ::geteuid() == 0 && cgroups::enabled() &&
         cgroups::hierarchy("freezer").isSome();
```

or 

```
  return ::geteuid() == 0 &&
         cgroups::enabled() &&
         cgroups::hierarchy("freezer").isSome();
```


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39604/#review103875
-----------------------------------------------------------


On Oct. 23, 2015, 10:21 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39604/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 10:21 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, and Kapil 
> Arya.
> 
> 
> Bugs: MESOS-3800
>     https://issues.apache.org/jira/browse/MESOS-3800
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We recently switched to using LinuxLauncher by default 
> (https://github.com/apache/mesos/blame/master/src/slave/containerizer/mesos/containerizer.cpp#L217-L234).
>  This causes problems with running the slave in a Docker container. 
> 
> This patch introduces a function for checking whether the machine is suited 
> for running Linux launcher. For the time being it checks whether the freezer 
> cgroup subsystem enabled, as the Linux launcher evolves we might want to add 
> more checks.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/linux_launcher.hpp 
> 35b3315498d690ed66616617aa7d51455371fb5b 
>   src/slave/containerizer/linux_launcher.cpp 
> c03b89eb0678825b03a052874d6262f377a39e13 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
> 
> Diff: https://reviews.apache.org/r/39604/diff/
> 
> 
> Testing
> -------
> 
> - Ran Mesoss tests in a Docker container where cgroup was not available.
> - Ran the new Jenkins script (https://reviews.apache.org/r/37787/).
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Reply via email to