----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/#review104064 -----------------------------------------------------------
Ship it! Thanks! src/slave/containerizer/linux_launcher.hpp (line 39) <https://reviews.apache.org/r/39604/#comment162287> Cna you rename it to 'available'? We tend to omit 'is' or 'are' for those functions (e.g., cgroups::enabled(), not cgroups::areEnabled()). - Jie Yu On Oct. 23, 2015, 11:48 p.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39604/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 11:48 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, and Kapil > Arya. > > > Bugs: MESOS-3800 > https://issues.apache.org/jira/browse/MESOS-3800 > > > Repository: mesos > > > Description > ------- > > We recently switched to using LinuxLauncher by default > (https://github.com/apache/mesos/blame/master/src/slave/containerizer/mesos/containerizer.cpp#L217-L234). > This causes problems with running the slave in a Docker container. > > This patch introduces a function for checking whether the machine is suited > for running Linux launcher. For the time being it checks whether the freezer > cgroup subsystem enabled, as the Linux launcher evolves we might want to add > more checks. > > > Diffs > ----- > > src/slave/containerizer/linux_launcher.hpp > 35b3315498d690ed66616617aa7d51455371fb5b > src/slave/containerizer/linux_launcher.cpp > c03b89eb0678825b03a052874d6262f377a39e13 > src/slave/containerizer/mesos/containerizer.cpp > d1fc5a460e7313828014eea999cf4e63dde01921 > > Diff: https://reviews.apache.org/r/39604/diff/ > > > Testing > ------- > > - Ran Mesoss tests in a Docker container where cgroup was not available. > - Ran the new Jenkins script (https://reviews.apache.org/r/37787/). > > > Thanks, > > Artem Harutyunyan > >
