> On Oct. 30, 2015, 2:16 p.m., Jie Yu wrote: > > src/slave/containerizer/linux_launcher.cpp, line 190 > > <https://reviews.apache.org/r/39604/diff/6/?file=1105496#file1105496line190> > > > > OK, this is problematic and almost caused us an incident at Twitter. > > > > Mesos is able to create 'freezer' hierarchy if it's not already > > mounted. In some configurations, the host won't pre-mount all cgroups > > hierarchies. We should remove that check here. > > Jie Yu wrote: > Chatted with Artem, a better way is to check: cgroups::enabled("freezer") > here
https://reviews.apache.org/r/39841/ - Artem ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/#review104619 ----------------------------------------------------------- On Oct. 23, 2015, 4:48 p.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39604/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 4:48 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, and Kapil > Arya. > > > Bugs: MESOS-3800 > https://issues.apache.org/jira/browse/MESOS-3800 > > > Repository: mesos > > > Description > ------- > > We recently switched to using LinuxLauncher by default > (https://github.com/apache/mesos/blame/master/src/slave/containerizer/mesos/containerizer.cpp#L217-L234). > This causes problems with running the slave in a Docker container. > > This patch introduces a function for checking whether the machine is suited > for running Linux launcher. For the time being it checks whether the freezer > cgroup subsystem enabled, as the Linux launcher evolves we might want to add > more checks. > > > Diffs > ----- > > src/slave/containerizer/linux_launcher.hpp > 35b3315498d690ed66616617aa7d51455371fb5b > src/slave/containerizer/linux_launcher.cpp > c03b89eb0678825b03a052874d6262f377a39e13 > src/slave/containerizer/mesos/containerizer.cpp > d1fc5a460e7313828014eea999cf4e63dde01921 > > Diff: https://reviews.apache.org/r/39604/diff/ > > > Testing > ------- > > - Ran Mesoss tests in a Docker container where cgroup was not available. > - Ran the new Jenkins script (https://reviews.apache.org/r/37787/). > > > Thanks, > > Artem Harutyunyan > >
