----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39636/#review103973 -----------------------------------------------------------
Patch looks great! Reviews applied: [39634, 39635, 39636] All tests passed. - Mesos ReviewBot On Oct. 26, 2015, 12:32 a.m., David Forsythe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39636/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2015, 12:32 a.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-1563 > https://issues.apache.org/jira/browse/MESOS-1563 > > > Repository: mesos > > > Description > ------- > > FreeBSD: Add basic support to stout > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp > dc7c6522b283916b975a77957909f6cdc02944d3 > 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp > 9428717fac4655898d7768957f02937592e1a398 > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > e49783a438157706b1be9745436bf666f45cab8b > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 7f70c9ea7d57634b5bfd40523ba37561ec92a09a > 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp > 3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp > 1baf142d53fd06149c80d4b2677c2a976c05ef71 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp > 828c9c777b1b0e067c2551b79b9747a3cf4fb0aa > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp > e9b05ef3b59fd068137cb12e36591de2d4a801a1 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp > 0a98e9e310d3931c2341053595b7d62f68214783 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp > 8a8ede325cfe8f024e1be4db24b0c8118d18f359 > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > b6afe0e76366d0bc68d37097ced83a1e14828d84 > 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp > 4cc781bddbf7ee10cc0671f62d710fb4fa80e293 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff > > Diff: https://reviews.apache.org/r/39636/diff/ > > > Testing > ------- > > make check on ubuntu 14.04 > > gmake check on FreeBSD 10.2 (failing, log attached) > > > File Attachments > ---------------- > > check.log > > https://reviews.apache.org/media/uploaded/files/2015/10/25/e661fec8-b342-440f-9b66-85bf0dd13fee__check.log > > > Thanks, > > David Forsythe > >
