----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review104106 -----------------------------------------------------------
support/apply-reviews.py (line 41) <https://reviews.apache.org/r/38883/#comment162331> capitalization of "Review ID" is different from above. please stick with one. support/apply-reviews.py (lines 56 - 57) <https://reviews.apache.org/r/38883/#comment162332> bad rebase? support/apply-reviews.py (line 78) <https://reviews.apache.org/r/38883/#comment162333> s/options/dry_run/ you can generalize it to 'options' later if there is a need for it. support/apply-reviews.py (line 96) <https://reviews.apache.org/r/38883/#comment162334> ditto. just take 'dry_run' as an argument. support/apply-reviews.py (line 113) <https://reviews.apache.org/r/38883/#comment162339> do you still need this if it's already in the atexit handler? support/apply-reviews.py (lines 116 - 132) <https://reviews.apache.org/r/38883/#comment162340> i'm not sure these need to be functions. you can just inline them. support/apply-reviews.py (line 134) <https://reviews.apache.org/r/38883/#comment162341> s/populate_// support/apply-reviews.py (line 157) <https://reviews.apache.org/r/38883/#comment162338> seems weird that a function called amend() checks to see if it can amend or not. i would've imagined the caller to do that. support/apply-reviews.py (line 173) <https://reviews.apache.org/r/38883/#comment162337> typically "-n" is used as a short argument for dry run. but i see why couldn't use it :( - Vinod Kone On Oct. 23, 2015, 6:18 a.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38883/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 6:18 a.m.) > > > Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, > and Vinod Kone. > > > Bugs: MESOS-3468 > https://issues.apache.org/jira/browse/MESOS-3468 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > support/apply-reviews.py PRE-CREATION > > Diff: https://reviews.apache.org/r/38883/diff/ > > > Testing > ------- > > Tested the script with python 2.7. > > > Thanks, > > Artem Harutyunyan > >
