> On Oct. 16, 2015, 4:15 p.m., Marco Massenzio wrote: > > Ship It! > > Marco Massenzio wrote: > Thanks for addressing comments!
hey, minor nit: I've just noticed you insert whitespaces around named args: ``` "....".format(url = USER_URL, user = username) ``` PEP8[0] requires that there are no spaces around the `=`: ``` format(url=USER_URL, user=username) ``` also in the default values around method params: ``` def do_it(name="foof", bar=None): ``` if you can fix before committing that'd be grand (but no big deal). Thanks! [0] https://www.python.org/dev/peps/pep-0008/#whitespace-in-expressions-and-statements ("""Don't use spaces around the = sign when used to indicate a keyword argument or a default parameter value.""") - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review102921 ----------------------------------------------------------- On Oct. 16, 2015, 3:29 p.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38883/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2015, 3:29 p.m.) > > > Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, > and Vinod Kone. > > > Bugs: MESOS-3468 > https://issues.apache.org/jira/browse/MESOS-3468 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > support/apply-reviews.py PRE-CREATION > > Diff: https://reviews.apache.org/r/38883/diff/ > > > Testing > ------- > > Tested the script with python 2.7. > > > Thanks, > > Artem Harutyunyan > >
