> On Oct. 26, 2015, 4:22 p.m., Vinod Kone wrote: > > support/apply-reviews.py, line 79 > > <https://reviews.apache.org/r/38883/diff/9/?file=1103869#file1103869line79> > > > > s/options/dry_run/ > > > > you can generalize it to 'options' later if there is a need for it.
I made `options` global. It makes things easier. > On Oct. 26, 2015, 4:22 p.m., Vinod Kone wrote: > > support/apply-reviews.py, line 106 > > <https://reviews.apache.org/r/38883/diff/9/?file=1103869#file1103869line106> > > > > ditto. just take 'dry_run' as an argument. See previous comment. > On Oct. 26, 2015, 4:22 p.m., Vinod Kone wrote: > > support/apply-reviews.py, lines 126-142 > > <https://reviews.apache.org/r/38883/diff/9/?file=1103869#file1103869line126> > > > > i'm not sure these need to be functions. you can just inline them. I could, but then it would make calling functions less readable. If you feel strongly about this one I can go ahead and change, for now I'll just drop. - Artem ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review104106 ----------------------------------------------------------- On Oct. 30, 2015, 1:54 a.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38883/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2015, 1:54 a.m.) > > > Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, > and Vinod Kone. > > > Bugs: MESOS-3468 > https://issues.apache.org/jira/browse/MESOS-3468 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > support/apply-reviews.py PRE-CREATION > > Diff: https://reviews.apache.org/r/38883/diff/ > > > Testing > ------- > > Tested the script with python 2.7. > > > Thanks, > > Artem Harutyunyan > >
