-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38577/#review104123
-----------------------------------------------------------

Ship it!



src/slave/validation.hpp (line 19)
<https://reviews.apache.org/r/38577/#comment162368>

    __SLAVE_VALIDATION_HPP__



src/slave/validation.hpp (line 31)
<https://reviews.apache.org/r/38577/#comment162369>

    why space here?



src/slave/validation.cpp (line 25)
<https://reviews.apache.org/r/38577/#comment162370>

    kill new line.



src/slave/validation.cpp (line 65)
<https://reviews.apache.org/r/38577/#comment162371>

    space before 'does'



src/slave/validation.cpp (line 75)
<https://reviews.apache.org/r/38577/#comment162372>

    also print status.source()



src/tests/executor_http_api_tests.cpp (line 502)
<https://reviews.apache.org/r/38577/#comment162373>

    kill this?



src/tests/executor_http_api_tests.cpp (line 504)
<https://reviews.apache.org/r/38577/#comment162374>

    make sure this pattern is consistent everywhere else in this file.


- Vinod Kone


On Oct. 27, 2015, 12:23 a.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38577/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2015, 12:23 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-2906
>     https://issues.apache.org/jira/browse/MESOS-2906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added validation for Call protobuf message in Agent /api/v1/executor endpoint.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e6169a0 
>   src/Makefile.am e797dac 
>   src/slave/http.cpp 3f7f71b 
>   src/slave/validation.hpp PRE-CREATION 
>   src/slave/validation.cpp PRE-CREATION 
>   src/tests/executor_http_api_tests.cpp e429d84 
> 
> Diff: https://reviews.apache.org/r/38577/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Reply via email to