> On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote: > > src/slave/validation.cpp, line 75 > > <https://reviews.apache.org/r/38577/diff/8/?file=1108615#file1108615line75> > > > > also print status.source() > > Isabel Jimenez wrote: > We don't have a stringify for this. > > Anand Mazumdar wrote: > Why not implement the `ostream` operator preferrably in `type_utils.hpp` > in a separate review and mark this one as dependent on it ? Otherwise, this > error string is hardly of any use to the end-user. What do you think?
+1 to anand's comment. but lets do that in a follow up review. i'll commit this chain now. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review104123 ----------------------------------------------------------- On Oct. 27, 2015, 1:20 a.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38577/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2015, 1:20 a.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-2906 > https://issues.apache.org/jira/browse/MESOS-2906 > > > Repository: mesos > > > Description > ------- > > Added validation for Call protobuf message in Agent /api/v1/executor endpoint. > > > Diffs > ----- > > src/CMakeLists.txt e6169a0 > src/Makefile.am e797dac > src/slave/http.cpp 3f7f71b > src/slave/validation.hpp PRE-CREATION > src/slave/validation.cpp PRE-CREATION > src/tests/executor_http_api_tests.cpp e429d84 > > Diff: https://reviews.apache.org/r/38577/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >
