-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39944/#review105114
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp (line 25)
<https://reviews.apache.org/r/39944/#comment163520>

    Why is this needed?
    And also we prefer Option<string> rather than an empty string default.


- Timothy Chen


On Nov. 4, 2015, 6:02 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39944/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2015, 6:02 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3815
>     https://issues.apache.org/jira/browse/MESOS-3815
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add prefix option for os::environment.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp 
> 91d82a8fae27c002458cad0bbdc45b312d2ec70d 
> 
> Diff: https://reviews.apache.org/r/39944/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to