> On Nov. 4, 2015, 6:58 p.m., Timothy Chen wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp, line 25
> > <https://reviews.apache.org/r/39944/diff/1/?file=1115742#file1115742line25>
> >
> >     Why is this needed?
> >     And also we prefer Option<string> rather than an empty string default.

Thank you. I replace with Option


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39944/#review105114
-----------------------------------------------------------


On Nov. 5, 2015, 3:18 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39944/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 3:18 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3815
>     https://issues.apache.org/jira/browse/MESOS-3815
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add prefix option for os::environment.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp 
> 91d82a8fae27c002458cad0bbdc45b312d2ec70d 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 
> 
> Diff: https://reviews.apache.org/r/39944/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to