> On Nov. 4, 2015, 6:28 p.m., Jojy Varghese wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp, line 25 > > <https://reviews.apache.org/r/39944/diff/1/?file=1115742#file1115742line25> > > > > Do you intend to copy the string each time? Or a const string& will do? > > > > As mentioned in the other review, maybe passing a set of prefixes or > > regular expressions would be useful.
Got it, let me update. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39944/#review105113 ----------------------------------------------------------- On Nov. 4, 2015, 6:02 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39944/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2015, 6:02 p.m.) > > > Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen. > > > Bugs: MESOS-3815 > https://issues.apache.org/jira/browse/MESOS-3815 > > > Repository: mesos > > > Description > ------- > > Add prefix option for os::environment. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp > 91d82a8fae27c002458cad0bbdc45b312d2ec70d > > Diff: https://reviews.apache.org/r/39944/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
