> On Nov. 5, 2015, 12:08 a.m., Ben Mahler wrote:
> > src/tests/mesos.cpp, line 447
> > <https://reviews.apache.org/r/39946/diff/1/?file=1115773#file1115773line447>
> >
> >     We tend to avoid abbreviations (like ctor, dtor):
> >     
> >     ```
> >     ?  mesos git:(master) ? grep -R destructor src | wc -l
> >           22
> >     ?  mesos git:(master) ? grep -R dtor src | wc -l
> >            0
> >     ```

Thanks! Fixed.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39946/#review105181
-----------------------------------------------------------


On Nov. 5, 2015, 12:56 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39946/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 12:56 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3827
>     https://issues.apache.org/jira/browse/MESOS-3827
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As discussed in MESOS-3827, this can improve compilation time of classes that
> use GMock. On my system, this improves the compilation time of the unit tests 
> by
> about 8%.
> 
> Note that we can't use this technique with TestAllocator, because it is
> templatized.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
>   src/tests/containerizer/launcher.hpp 
> 5d34bab789bdafe71d94e8ec263710c50b83e180 
>   src/tests/containerizer/launcher.cpp PRE-CREATION 
>   src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217 
>   src/tests/mesos.cpp ab2d85b091d121113931e4190a5b496901dcd7a5 
> 
> Diff: https://reviews.apache.org/r/39946/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to