-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39946/#review108010
-----------------------------------------------------------

Ship it!



src/Makefile.am (line 1740)
<https://reviews.apache.org/r/39946/#comment167383>

    alignment.



src/tests/containerizer/launcher.cpp (line 46)
<https://reviews.apache.org/r/39946/#comment167379>

    indentation.



src/tests/mesos.cpp (lines 463 - 473)
<https://reviews.apache.org/r/39946/#comment167374>

    indentation.



src/tests/mesos.cpp (lines 482 - 490)
<https://reviews.apache.org/r/39946/#comment167375>

    indentation.



src/tests/mesos.cpp (lines 498 - 507)
<https://reviews.apache.org/r/39946/#comment167376>

    indentation.



src/tests/mesos.cpp (lines 634 - 637)
<https://reviews.apache.org/r/39946/#comment167378>

    indentation.


- Joris Van Remoortere


On Nov. 23, 2015, 5:10 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39946/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2015, 5:10 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3827
>     https://issues.apache.org/jira/browse/MESOS-3827
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As discussed in MESOS-3827, this can improve compilation time of classes that
> use GMock. On my system, this improves the compilation time of the unit tests 
> by
> about 8%.
> 
> Note that we can't use this technique with TestAllocator, because it is
> templatized.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
>   src/tests/containerizer/launcher.hpp 
> 09c4ba29d6240a3fbc132d82733d7df7b28e00a1 
>   src/tests/containerizer/launcher.cpp PRE-CREATION 
>   src/tests/mesos.hpp a2a76f55f9a4091cccfccd9672c2d2897b34ddcd 
>   src/tests/mesos.cpp b2211d59ed571ec8ddc132f69ed1cf5da9eeef10 
> 
> Diff: https://reviews.apache.org/r/39946/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to