-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review105339
-----------------------------------------------------------



src/tests/master_quota_tests.cpp (lines 110 - 112)
<https://reviews.apache.org/r/38956/#comment163897>

    The resource string you have is equivalent to the resource string from 
`CreateSlaveFlags`.  Is there some reason you're re-setting it?



src/tests/master_quota_tests.cpp (lines 147 - 148)
<https://reviews.apache.org/r/38956/#comment163896>

    Rather than re-defining this, can you populate it via the result of 
`MesosTest::CreateSlaveFlags().resources`?



src/tests/master_quota_tests.cpp (line 201)
<https://reviews.apache.org/r/38956/#comment163898>

    Can you change this comment to more closely match your test?
    
    I find `12 > 11` to be a better sanity check than `100 > 11`.


- Joseph Wu


On Nov. 5, 2015, 11:27 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 11:27 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
>     https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/quota_handler.cpp PRE-CREATION 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to