> On Nov. 5, 2015, 4:39 p.m., Joseph Wu wrote:
> > src/tests/master_quota_tests.cpp, lines 110-112
> > <https://reviews.apache.org/r/38956/diff/8/?file=1114104#file1114104line110>
> >
> >     The resource string you have is equivalent to the resource string from 
> > `CreateSlaveFlags`.  Is there some reason you're re-setting it?
> 
> Alexander Rukletsov wrote:
>     One of the comments I got earlier from Bernd is that it is hard to track 
> what resources are available, hence I decided to re-introduce the resources 
> explicitly.

Can you add a comment about this to the test?


> On Nov. 5, 2015, 4:39 p.m., Joseph Wu wrote:
> > src/tests/master_quota_tests.cpp, lines 147-148
> > <https://reviews.apache.org/r/38956/diff/8/?file=1114104#file1114104line147>
> >
> >     Rather than re-defining this, can you populate it via the result of 
> > `MesosTest::CreateSlaveFlags().resources`?
> 
> Alexander Rukletsov wrote:
>     Do you suggest to call `MesosTest::CreateSlaveFlags()` in the `SetUp()` 
> in order to use just the `.resources` artifact? Or you think I should make 
> `defaultAgentResources` local in every test?

This ties in with the above issue.  Given what Bernd/you said, what you have is 
probably ok.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review105339
-----------------------------------------------------------


On Nov. 10, 2015, 2 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2015, 2 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
>     https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am ae2740a5b56351d9fd82ae3bd5c733d10a90bf2f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to