> On Oct. 8, 2015, 10:21 a.m., Bernd Mathiske wrote: > > src/tests/master_quota_tests.cpp, line 132 > > <https://reviews.apache.org/r/38956/diff/1/?file=1088991#file1088991line132> > > > > How about adding each test function and have it do nothing, with a TODO > > inside, but with a comment of the top what it is supposed to test - instead > > of this comment? > > Alexander Rukletsov wrote: > It's a good idea, I'll do that.
After the second thought, I think a TODO is better. The stubs for tests with comments can become outdated in a while, so I would prefer not to invest much effort into it. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/#review101885 ----------------------------------------------------------- On Nov. 5, 2015, 7:27 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38956/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 7:27 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > Joseph Wu, and Michael Park. > > > Bugs: MESOS-3720 > https://issues.apache.org/jira/browse/MESOS-3720 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 > src/master/quota_handler.cpp PRE-CREATION > src/tests/master_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38956/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
