----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/ -----------------------------------------------------------
(Updated Nov. 6, 2015, 6:24 a.m.) Review request for mesos, Joris Van Remoortere and Michael Park. Changes ------- Addressed all of mpark comments Bugs: MESOS-3035 https://issues.apache.org/jira/browse/MESOS-3035 Repository: mesos Description (updated) ------- The original API for `process::Subprocess` still left a lot of legwork to do for the caller; we have now added an `execute()` method that returns a `Future<Subprocess::Result>`. `Subprocess::Result`, also introduced with this patch, contains useful information about the command invocation (an `Invocation` struct); the exit code; `stdout`; and, optionally, `stderr` too. Once the Future completes, if successful, the caller will be able to retrieve stdout/stderr; whether the command was successful; and whether it received a signal Diffs (updated) ----- 3rdparty/libprocess/include/process/subprocess.hpp f17816e813d5efce1d3bb1ff1e1111850eeda3ba 3rdparty/libprocess/src/subprocess.cpp efe0018d0414c4137fd833c153eb262232e712bc 3rdparty/libprocess/src/tests/subprocess_tests.cpp ac600a551fb1a7782ff33cce204b7819497ef54a Diff: https://reviews.apache.org/r/37336/diff/ Testing (updated) ------- make check (also tested functionality with an anonymous module that exposes an `/execute` endpoint and runs arbitrary commands, asynchronously, on an Agent) Thanks, Marco Massenzio