> On Nov. 3, 2015, 12:35 p.m., Alexander Rukletsov wrote:
> > src/tests/master_quota_tests.cpp, line 463
> > <https://reviews.apache.org/r/39223/diff/6/?file=1105362#file1105362line463>
> >
> >     We try to keep tests atomic: testing one thing at a time. However, I 
> > think it does make sense to merge `Set_InvalidJson`, `Set_InvalidJson2`, 
> > and `Set_InvalidResources` into one tests for brevity and speed. These 3 
> > tests address the same issue: malformed JSON, similar to what you have done 
> > with `Set_InvalidResourceInfos`.

I feel that these are actually testing slightly different stuff (different from 
the invalidResource Info)


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39223/#review104894
-----------------------------------------------------------


On Oct. 23, 2015, 9:10 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39223/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 9:10 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3199
>     https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see Summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39223/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to