> On Nov. 8, 2015, 2:24 a.m., Guangya Liu wrote: > > src/tests/master_quota_tests.cpp, lines 209-210 > > <https://reviews.apache.org/r/39223/diff/7/?file=1118237#file1118237line209> > > > > Can you please make this comments limit in 70 per line and ditto for > > the following? > > Alexander Rukletsov wrote: > Why do you suggest to limit to 70?
Well, I do not have strong opinion on this but as we are now still discussing http://search-hadoop.com/m/0Vlr6MlNkc1FGzCj2/Mesos+Style+Guideline+Adjustments%25E2%2580%258F+Ben+Mahler+This+has+come+up+in+a+couple+of+reviews%252C+seems+like+we+should+add+some+soft&subj=Re+Mesos+Style+Guideline+Adjustments this. But keeping the comments limit in 70 chars can make the comments more readable here as the two lines will almost have same length. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review105600 ----------------------------------------------------------- On Nov. 6, 2015, 5:02 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39223/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2015, 5:02 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > ------- > > see Summary. > > > Diffs > ----- > > src/tests/master_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39223/diff/ > > > Testing > ------- > > > Thanks, > > Joerg Schad > >
