----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39594/#review105488 -----------------------------------------------------------
As discussed, let's re-iterate on the actual function / signature. 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 130) <https://reviews.apache.org/r/39594/#comment164103> Add blank line here please. 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (lines 131 - 135) <https://reviews.apache.org/r/39594/#comment164104> According to our doxygen-styleguide, we are using C comments; ``` /** * * */ ``` 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 141) <https://reviews.apache.org/r/39594/#comment164107> Why not use `nullptr` instead? 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 142) <https://reviews.apache.org/r/39594/#comment164105> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 154) <https://reviews.apache.org/r/39594/#comment164108> s/0/CURLE_OK/ - Till Toenshoff On Nov. 6, 2015, 7:52 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39594/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2015, 7:52 p.m.) > > > Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff. > > > Bugs: MESOS-3785 > https://issues.apache.org/jira/browse/MESOS-3785 > > > Repository: mesos > > > Description > ------- > > [stout]: Added function to simultaneously query size and mtime of URI. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp > 311b00b41398a9fd7374f3847190468ba59c1dc9 > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > e49783a438157706b1be9745436bf666f45cab8b > > Diff: https://reviews.apache.org/r/39594/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Bannier > >
